Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: Added events and defer prop to ScrollArea #744

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

albinAppsmith
Copy link
Contributor

Description

This PR adds defer and events props to ScrollArea component.

Fixes appsmithorg/appsmith#34378

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 8:01am

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 4a92d08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@albinAppsmith albinAppsmith merged commit a692320 into release Jun 24, 2024
8 checks passed
@albinAppsmith albinAppsmith deleted the improve-scrollbar-events-defer branch June 24, 2024 04:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] - Add events & defer param to scroll area component
2 participants