free strdupped temporary variable in joinpath

[DrDaveD]

Description of the Pull Request (PR):

I noticed a strdup() in joinpath() that was not getting freed and not needed after the function returns. This adds the free().

This fixes or addresses the following GitHub issues:

• None

Checkoff for all PRs:

• I have read the Guidelines for Contributing, and this PR conforms to the stated requirements.
• I have added changes to the CHANGELOG and and documentation updates to the singularityware documentation base.
• I have tested this PR locally with a make test
• This PR is NOT against the project's master branch
• I have added myself as a contributor to the contributors's file
• This PR is ready for review and/or merge

Attn: @singularityware-admin

[GodloveD]

Nice catch. Should the free also go into the preceding if statement just in case the function bombs out?

[GodloveD]

Should the free also go in this if statement above?

[DrDaveD]

I didn't think it was worth doing since the program dies there anyway.

[GodloveD]

Your right.

[lyklev]

I noticed that indeed where joinpath and strdup are used, most of the time it leaks memory. It was my intention to fix it in a few places, but the memory leaking is quite common. I have started working on it, and will probably fix the memory leaks in small steps, in many commits to make the fix easier to test and review.

[lyklev]

Yes, it is, it is one of the many places where strdup without a free leaks memory.

It was my intention to fix the memory leaks bit by bit, mostly by using static variables where possible. In fact, some of the fixes are already in my "strings-fix" branch for which I have not made any pull requests yet - but feel free to have a look.