Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display errno string for realpath for debug purpose #1535

Merged
merged 1 commit into from
May 11, 2018
Merged

Display errno string for realpath for debug purpose #1535

merged 1 commit into from
May 11, 2018

Conversation

cclerget
Copy link
Collaborator

Description of the Pull Request (PR):

This PR display string error for realpath, since realpath can fail for many reasons not necessary because path don't exist, that will help during debug.

Checkoff for all PRs:

  • I have read the Guidelines for Contributing, and this PR conforms to the stated requirements.
  • I have added changes to the CHANGELOG and and documentation updates to the singularityware documentation base.
  • I have tested this PR locally with a make test
  • This PR is NOT against the project's master branch
  • I have added myself as a contributor to the contributors's file
  • This PR is ready for review and/or merge

Attn: @singularityware-admin

GodloveD
GodloveD approved these changes May 11, 2018
View reviewed changes
Copy link
Collaborator

@GodloveD GodloveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@GodloveD GodloveD merged commit 21f6754 into apptainer:release-2.5 May 11, 2018
@GodloveD
Copy link
Collaborator

Also cherry-picked into development-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmstover jmstover jmstover approved these changes

@GodloveD GodloveD GodloveD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclerget @GodloveD @jmstover