Pull --debug fix on docker:// URI #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pull on a docker:// URI, so if debug (-d) is passed, we pass the debug flag when we run the `singularity build` command.
bauerm97
reviewed
May 21, 2018
| if [ -x "${SINGULARITY_bindir}/singularity" ]; then | ||
| ${SINGULARITY_bindir}/singularity build ${SINGULARITY_IMAGE} ${SINGULARITY_CONTAINER} | ||
| DBGFLAG="" | ||
| if [ "x${SINGULARITY_MESSAGELEVEL}" == "x5" ]; then |
There was a problem hiding this comment.
Why does this say "x$... and "x5" instead of "$... and "5"?
There was a problem hiding this comment.
Because if SINGULARITY_MESSAGELEVEL is not set, you could end up like:
if [ == 5 ]; then
And not have a left hand side. So ... it's common practice to add an x in, so the check ends up as:
if [ x == x5 ]; then
dtrudg
approved these changes
May 22, 2018
GodloveD
pushed a commit
that referenced
this pull request
May 22, 2018
Pull --debug fix on docker:// URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
When we
pullfrom adocker://URI, we aren't passing the debug flag if it was used. CheckSINGULARITY_MESSAGELEVEL, and if5(debug), pass the-dflag to thesingularity buildThis fixes or addresses the following GitHub issues:
Checkoff for all PRs:
make testAttn: @singularityware-admin