Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove environment variables eval for --bind, --nv and --rocm for build command #6211

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Remove environment variables eval for --bind, --nv and --rocm for build command #6211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93591a7
Remove environment variables eval for --bind, --nv and --rocm for bui…
cclerget Oct 7, 2021
b647824
Merge branch 'master' into issue-6181
DrDaveD Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@
Docker/OCI container.
- Instances are no longer created with an IPC namespace by default. An IPC
namespace can be specified with the `-i|--ipc` flag.
- `--bind`, `--nv` and `--rocm` options for `build` command can't be set through
environment variables `SINGULARITY_BIND`, `SINGULARITY_BINDPATH`, `SINGULARITY_NV`,
`SINGULARITY_ROCM` anymore due to side effects reported by users in this
[issue](https://github.com/hpcng/singularity/pull/6211), they must be explicitely
requested via command line.
- `--nohttps` flag has been deprecated in favour of `--no-https`. The old flag
is still accepted, but will display a deprecation warning.
- Removed `--nonet` flag, which was intended to disable networking for in-VM
Expand Down
4 changes: 0 additions & 4 deletions cmd/internal/cli/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ var buildNvFlag = cmdline.Flag{
DefaultValue: false,
Name: "nv",
Usage: "inject host Nvidia libraries during build for post and test sections (not supported with remote build)",
EnvKeys: []string{"NV"},
}

// --rocm
Expand All @@ -225,7 +224,6 @@ var buildRocmFlag = cmdline.Flag{
DefaultValue: false,
Name: "rocm",
Usage: "inject host Rocm libraries during build for post and test sections (not supported with remote build)",
EnvKeys: []string{"ROCM"},
}

// -B|--bind
Expand All @@ -240,8 +238,6 @@ var buildBindFlag = cmdline.Flag{
"it is set equal to src. Mount options ('opts') may be specified as 'ro'" +
"(read-only) or 'rw' (read/write, which is the default)." +
"Multiple bind paths can be given by a comma separated list. (not supported with remote build)",
EnvKeys: []string{"BIND", "BINDPATH"},
EnvHandler: cmdline.EnvAppendValue,
}

// --writable-tmpfs
Expand Down