Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreadCount incremented when typing a message #70

Closed
owenfi opened this issue Nov 19, 2013 · 4 comments
Closed

unreadCount incremented when typing a message #70

owenfi opened this issue Nov 19, 2013 · 4 comments

Comments

@owenfi
Copy link
Contributor

owenfi commented Nov 19, 2013

unreadCount should reflect the number of messages a user has not seen, but in a case I found it is possible to falsely increment unreadCount.

The scenario is: A user begins editing a message in the inputView in the messageCenter class. As soon as the first letter is entered a breakpoint in ATBackend controllerDidChangeContent: will trigger and you can see that unread count goes to 1. (Clearing the text field or leaving the view decrements to zero, as "expected")

The problem is: If the user quits the with characters remaining in the inputView text field then the unreadCount is falsely stuck at 1 (until the next message center load, etc.)

If this is by design I think the inputView should re-populate the previous text on returning to the message center, but I think the unread count should actually either 1. Not increment while editing (or ever, for user driven messages?) or 2. Refresh to the proper value when Apptentive first loads.

@pkamb
Copy link
Contributor

pkamb commented Nov 19, 2013

Thanks for the report on this @owenfi. I'll look into it today.

pkamb added a commit that referenced this issue Nov 20, 2013
… a new message.

When user starts composing a message, now marking it as `sentByUser` and `seenByUser`
Fixes #70
Fixes IOS-310
@pkamb
Copy link
Contributor

pkamb commented Nov 20, 2013

Thanks for the report @owenfi, this will be in the next release.

@pkamb pkamb closed this as completed Nov 20, 2013
@justinelsberry
Copy link

@pkamb is this supposed to be in 1.2.4? We are using CocoaPods 1.2.4 podspec and it still appears to fire the unread message count change when typing a new message in the message center. Is there a branch we can point CocoaPods to and use in production that will include this fix?

pkamb added a commit that referenced this issue Jan 13, 2014
…sing a new message.

When user starts composing a message, now marking it as `sentByUser` and `seenByUser`
Fixes #70
Fixes IOS-310
CC 7b80707
@pkamb
Copy link
Contributor

pkamb commented Jan 13, 2014

Ah, thanks @justinelsberry for the report. There was a regression after our recent iOS 7 visual changes. I've just pushed a fix; feel free to pull in the same into your local copy. We are also planning on pushing a release later this week, at which point you can get the update via cocoapods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants