fix: material sources duplicated #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luhc228
commented
Oct 13, 2020
•
luhc228
commented
- Fix: material sources display duplicated
alvinhui
reviewed
Oct 13, 2020
| @@ -83,7 +83,7 @@ export async function getSources(specifiedType?: string): Promise<IMaterialSourc | |||
| sources = sources.concat(OFFICAL_MATERIAL_SOURCES_FOR_EXTERNAL); | |||
| } | |||
| const userSources: IMaterialSource[] = getUserSources(); | |||
| sources.unshift(...userSources); | |||
| sources = [...userSources, ...sources]; | |||
There was a problem hiding this comment.
建议是改第 66 行代码：[].concat(OFFICAL_MATERIAL_SOURCES);
luhc228
force-pushed
the
fix/material-sources-display-duplicated
branch
from
ba686d2
to
5eaa88f
Compare
alvinhui
approved these changes
Oct 13, 2020
Codecov Report
@@ Coverage Diff @@
## hotfix/undefined #613 +/- ##
=================================================
Coverage 57.14% 57.14%
=================================================
Files 1 1
Lines 70 70
Branches 15 15
=================================================
Hits 40 40
Misses 30 30 Continue to review full report at Codecov.
|
alvinhui
approved these changes
Oct 13, 2020
delete-merged-branch
bot
deleted the
fix/material-sources-display-duplicated
branch
alvinhui
added a commit
that referenced
this pull request
Oct 13, 2020
* fix: scaffold is empty * fix: welcome page auto show logic * docs: changelog for iceworks app * fix: material sources duplicated (#613) * fix: material sources duplicated * chore: changelog * fix: comment Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.