feat: loading status when reinstalling deps #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/1.2.1 #896 +/- ##
==============================================
Coverage 57.14% 57.14%
==============================================
Files 1 1
Lines 70 70
Branches 15 15
==============================================
Hits 40 40
Misses 30 30 Continue to review full report at Codecov.
|
fyangstudio
reviewed
Jul 7, 2021
extensions/application-manager/src/views/nodeDependenciesView.ts
Outdated
Show resolved
Hide resolved
Merged
fyangstudio
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景：点击“重装依赖”，会先删除 node_modules 目录，然后进行 npm install。但删除 node_modules 的过程中没有任何提示货反馈，需要增加 loading 的状态以获得更好的用户体验。
Preview:
