Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import auto complete #905

Merged
merged 7 commits into from
Jul 21, 2021
Merged

Conversation

GiveMe-A-Name
Copy link
Contributor

import auto complete

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #905 (984a836) into release/1.3.0 (2a1eac4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.3.0     #905   +/-   ##
==============================================
  Coverage          57.14%   57.14%           
==============================================
  Files                  1        1           
  Lines                 70       70           
  Branches              15       15           
==============================================
  Hits                  40       40           
  Misses                30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1eac4...984a836. Read the comment docs.

@luhc228
Copy link
Contributor

luhc228 commented Jul 19, 2021

看一下冲突

Copy link
Collaborator

@fyangstudio fyangstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

逻辑建议上分成
getStoreItems (store model)
getFrameworkItems (rax、ice)
getComponentItems
getStyleItems (补充:发现用户在编辑 jsx 文件时同时没引 stlye 文件时触发 )
getFileItems (现 file 部分)

同时 最好写点注释,补充一些注释上的示例 可以让代码有更好的可读性

@fyangstudio fyangstudio merged commit e6e67aa into release/1.3.0 Jul 21, 2021
@fyangstudio fyangstudio deleted the feat/import-auxiliary branch July 21, 2021 02:31
@fyangstudio fyangstudio mentioned this pull request Jul 21, 2021
fyangstudio added a commit that referenced this pull request Jul 22, 2021
* fix: override.files neo work

* feat: update

* Feat/prop types auto complete (#902)

* feat: complete proptypes

* feat: code snippets (#903)

* feat: auto fill content in store's files

* docs: update changelog (#909)

* refactor: variable rename

* fix: dashboard error in external (#911)

* feat: import auto complete (#905)

* feat: import-auto-complete

* feat: export types (#904)

* feat: import auto completion  (#914)

* feat: import auto complete

* feat: update release (#913)

* fix: code snippets (#915)

* fix: code snippets

* feat: update registry

Co-authored-by: GiveMe-A-Name <58852732+GiveMe-A-Name@users.noreply.github.com>
Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com>
Co-authored-by: GiveMe-A-Name <a455300764b@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants