Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mention of the new CiliumNetworkPolicy in the appropriate documentation #197

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Make mention of the new CiliumNetworkPolicy in the appropriate documentation #197

merged 2 commits into from
Jun 12, 2024

Conversation

HappyTetrahedron
Copy link
Contributor

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    how-to, tutorial, reference, explanation, cicd, dependency
    as they show up in the changelog

@HappyTetrahedron HappyTetrahedron added the how-to A how-to documentation page label Jun 12, 2024
simu
simu approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added my understanding of which policy is required for what inline.

IIRC the allow-from-other-namespaces policy doesn't apply to the hostNetwork: true router pods with Cilium

docs/modules/ROOT/pages/how-to/remove-default-networkpolicies.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-to/remove-default-networkpolicies.adoc Outdated Show resolved Hide resolved
@HappyTetrahedron @simu
Apply suggestions from code review
670fabf 
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@HappyTetrahedron
Copy link
Contributor Author

excellent additions, thanks!

@HappyTetrahedron HappyTetrahedron merged commit 8c568fe into master Jun 12, 2024
1 check passed
@HappyTetrahedron HappyTetrahedron deleted the cilium-netpol branch June 12, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
how-to A how-to documentation page
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HappyTetrahedron @simu