Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add GitLab CI setup #2

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Add GitLab CI setup #2

merged 2 commits into from
Aug 19, 2020

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Aug 6, 2020

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update the ./CHANGELOG.md.

@srueg srueg requested review from corvus-ch and simu August 11, 2020 13:25
simu
simu reviewed Aug 17, 2020
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable overall, as commented inline, tagging the jobs with "unpriv_dockerbuild" is only going to work as expected on git.vshn.net.

component/gitlab-ci.jsonnet Outdated Show resolved Hide resolved
@corvus-ch corvus-ch merged commit 8ae14cf into master Aug 19, 2020
@corvus-ch corvus-ch deleted the gitlab-ci branch August 19, 2020 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simu simu simu left review comments

@corvus-ch corvus-ch Awaiting requested review from corvus-ch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srueg @simu @corvus-ch