Run elasticsearch operator on infra nodes #44
Conversation
bastjan
force-pushed
the
operator-on-infra-nodes
branch
from
11c1300 to
205f9ac
Compare
| } + (import 'kibana-host.libsonnet') | ||
| } | ||
| + (import 'kibana-host.libsonnet') | ||
| + (import 'deployment-patch.libsonnet') |
There was a problem hiding this comment.
I think we should address scheduling of operator pods which are managed through component openshift4-operators in that component (https://github.com/appuio/component-openshift4-operators) and not in the components which make use of component openshift4-operators.
I'd suggest to simply set the openshift.io/node-selector: node-role.kubernetes.io/infra= annotation on the namespaces managed by that component.
Alternatively the component library of component openshift4-operators could support configuring deployment patches, but I don't think that's actually necessary in this case, since we'll always want all operators to run on the infra nodes, if there are any.
There was a problem hiding this comment.
That was my first instinct too. But i found the openshift.io/node-selector annotation already explicitly set to empty.
But I'm unsure if this is really needed...
There was a problem hiding this comment.
Looks like I copied that from the official instructions, cf. https://docs.openshift.com/container-platform/4.9/logging/cluster-logging-deploying.html#cluster-logging-deploy-cli_cluster-logging-deploying but I don't see how that's necessary unless some operators need to run on the control plane nodes.
I'd propose to go ahead and change the annotation in that component, since there's no real reason for the operator deployments themselves to run on specific nodes.
There was a problem hiding this comment.
👍 makes for a way simpler change
There was a problem hiding this comment.
+1 makes for a way simpler change
IMO the even bigger upside is that we don't need to copy-paste this change to any component which installs an operator via the openshift4-operators component library.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.