Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 10 commits into from
Jul 29, 2021
Merged

Initial implementation #1

merged 10 commits into from
Jul 29, 2021

Conversation

simu
Copy link
Member

@simu simu commented Jul 28, 2021

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@simu simu added the enhancement New feature or request label Jul 28, 2021
@simu simu force-pushed the initial-implementation branch 2 times, most recently from 25e72f3 to 806f3a8 Compare July 28, 2021 14:45
@simu simu requested review from megian and corvus-ch July 28, 2021 15:06
simu added 7 commits July 28, 2021 17:22
Restrict supported instances to 'openshift-operators' and
'openshift-operators-redhat'.
Create cluster-scoped OperatorGroup in instance namespace.
Reuse and extend instance verification function to produce an error if a
user tries to create a subscription for an instance (== namespace) which
isn't managed by the component.
* Update index.adoc
* Add getting started guide
* Document parameters
Allow users to override default values for optional parameters of
`registerSubscription` through the hierarchy.

The component provides sensible defaults for both supported instances.
Also rename `registerSubscription` to `globalSubscription`.
lib/openshift4-operators.libsonnet Show resolved Hide resolved
class/defaults.yml Outdated Show resolved Hide resolved
lib/openshift4-operators.libsonnet Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/getting-started.adoc Outdated Show resolved Hide resolved
@simu simu force-pushed the initial-implementation branch from dedf03f to ac3e333 Compare July 29, 2021 07:24
Also change the getting started example to use elasticsearch-eck-operator-certified

Co-authored-by: Megian <gabisoft@freesurf.ch>
@simu simu force-pushed the initial-implementation branch 2 times, most recently from 950ee9e to 41b51a4 Compare July 29, 2021 08:17
simu added 2 commits July 29, 2021 10:28
Reduce amount of duplicated code in component lib
* Function comments in library
* Page in component documentation
@simu simu force-pushed the initial-implementation branch from 5116e16 to 74883dc Compare July 29, 2021 08:29
Copy link
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where ever that one did come from. Thanks and thanks for the extended documentation.

@simu simu merged commit 795751b into master Jul 29, 2021
@simu simu deleted the initial-implementation branch July 29, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants