-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25e72f3
to
806f3a8
Compare
Restrict supported instances to 'openshift-operators' and 'openshift-operators-redhat'.
Create cluster-scoped OperatorGroup in instance namespace.
Reuse and extend instance verification function to produce an error if a user tries to create a subscription for an instance (== namespace) which isn't managed by the component.
* Update index.adoc * Add getting started guide * Document parameters
Allow users to override default values for optional parameters of `registerSubscription` through the hierarchy. The component provides sensible defaults for both supported instances.
Also rename `registerSubscription` to `globalSubscription`.
5139833
to
77c869d
Compare
4 tasks
megian
requested changes
Jul 28, 2021
dedf03f
to
ac3e333
Compare
megian
approved these changes
Jul 29, 2021
Also change the getting started example to use elasticsearch-eck-operator-certified Co-authored-by: Megian <gabisoft@freesurf.ch>
950ee9e
to
41b51a4
Compare
Reduce amount of duplicated code in component lib
* Function comments in library * Page in component documentation
5116e16
to
74883dc
Compare
corvus-ch
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where ever that one did come from. Thanks and thanks for the extended documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog