Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of custom namespace names for this component #22

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

HappyTetrahedron
Copy link
Contributor

@HappyTetrahedron HappyTetrahedron commented Mar 6, 2023

This allows the component to be deployed into arbitrary namespaces. Since this is officially a "workaround", this feature has to be enabled explicitly via parameters; by default, the validation rejects non-standard namespaces as usual.

Additionally, fixed some potential naming conflicts in the output directory and argocd app.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron added the enhancement New feature or request label Mar 6, 2023
@HappyTetrahedron HappyTetrahedron requested a review from simu March 6, 2023 15:31
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General remark: We don't mention internal tickets in commits/PRs on GitHub to avoid information disclosure.

component/app.jsonnet Outdated Show resolved Hide resolved
@HappyTetrahedron HappyTetrahedron force-pushed the feat/allow-custom-namespaces branch 2 times, most recently from f92b98c to b8702d5 Compare March 6, 2023 16:09
@HappyTetrahedron HappyTetrahedron merged commit 8839332 into master Mar 6, 2023
@HappyTetrahedron HappyTetrahedron deleted the feat/allow-custom-namespaces branch March 6, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants