Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't take over ownership of OpenShift-managed namespace openshift-operators #27

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

simu
Copy link
Member

@simu simu commented Mar 8, 2023

The namespace openshift-operators is created and managed by OpenShift itself (via the cluster-version-operator). Until now the component would have taken over ownership of the namespace when used as instance openshift-operators. This could lead to undesirable side-effects, such as manually installed operators getting removed when the component instance is deactivated.

This PR updates the component to only create a patch to add our desired labels and annotations to the namespace if it's instantiated for namespace openshift-operators.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@simu simu added the bug Something isn't working label Mar 8, 2023
@simu simu changed the title Don't take over ownership of OpenShift-managed namespace `openshift-o… Don't take over ownership of OpenShift-managed namespace openshift-operators Mar 8, 2023
Base automatically changed from fix/multi-instance to master March 9, 2023 10:14
@simu simu force-pushed the fix/openshift-operators branch from ef328cf to ddb2a9e Compare March 9, 2023 10:14
@simu simu requested a review from bastjan March 9, 2023 10:15
@simu simu merged commit 645b243 into master Mar 10, 2023
@simu simu deleted the fix/openshift-operators branch March 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants