Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using git-https and curl in Terraform #10

Merged
merged 8 commits into from
Jul 2, 2021

Conversation

simu
Copy link
Member

@simu simu commented Jun 22, 2021

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@simu simu self-assigned this Jun 22, 2021
@simu simu force-pushed the feat/custom-tf-script branch from 1ebd8c7 to d7d0e94 Compare June 23, 2021 13:52
@simu simu added the enhancement New feature or request label Jun 23, 2021
@simu
Copy link
Member Author

simu commented Jun 23, 2021

The Exoscale test is failing because appuio/terraform-openshift4-exoscale#10 is not merged yet.

@simu simu force-pushed the feat/custom-tf-script branch 2 times, most recently from 44f6fda to 2f96e6b Compare June 23, 2021 14:34
@simu simu force-pushed the feat/custom-tf-script branch from 2f96e6b to 24d462a Compare June 29, 2021 13:03
@simu simu marked this pull request as ready for review June 29, 2021 13:04
@simu simu requested review from ccremer and corvus-ch June 29, 2021 13:04
@simu simu force-pushed the feat/custom-tf-script branch from 24d462a to 48432cd Compare July 2, 2021 06:53
simu added 7 commits July 2, 2021 08:54
The wrapper script needs two stages, since we currently want to execute
some preparatory commands as root (e.g. install `curl`), before
switching to an unprivileged user for actually running Terraform.

Additionally, we set `GIT_ASKPASS` to the provided `git-askpass.sh`
script, so we can support Git-over-HTTPS for private repositories.

Using Git-over-HTTPS removes the need for providing an execution
environment for SSH and means we only need to provide a token/password
instead of a SSH private key in the Terraform CI environment.
@simu simu force-pushed the feat/custom-tf-script branch from 48432cd to c8f73bc Compare July 2, 2021 06:54
@simu simu merged commit fdc127a into master Jul 2, 2021
@simu simu deleted the feat/custom-tf-script branch July 2, 2021 06:56
@simu simu changed the title Custom Terraform scripts Support for using git-https and curl in Terraform Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants