-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for using git-https and curl in Terraform #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/custom-tf-script
branch
from
June 23, 2021 13:52
1ebd8c7
to
d7d0e94
Compare
The Exoscale test is failing because appuio/terraform-openshift4-exoscale#10 is not merged yet. |
simu
force-pushed
the
feat/custom-tf-script
branch
2 times, most recently
from
June 23, 2021 14:34
44f6fda
to
2f96e6b
Compare
simu
force-pushed
the
feat/custom-tf-script
branch
from
June 29, 2021 13:03
2f96e6b
to
24d462a
Compare
ccremer
approved these changes
Jun 29, 2021
corvus-ch
approved these changes
Jun 30, 2021
simu
force-pushed
the
feat/custom-tf-script
branch
from
July 2, 2021 06:53
24d462a
to
48432cd
Compare
The wrapper script needs two stages, since we currently want to execute some preparatory commands as root (e.g. install `curl`), before switching to an unprivileged user for actually running Terraform. Additionally, we set `GIT_ASKPASS` to the provided `git-askpass.sh` script, so we can support Git-over-HTTPS for private repositories. Using Git-over-HTTPS removes the need for providing an execution environment for SSH and means we only need to provide a token/password instead of a SSH private key in the Terraform CI environment.
simu
force-pushed
the
feat/custom-tf-script
branch
from
July 2, 2021 06:54
48432cd
to
c8f73bc
Compare
simu
changed the title
Custom Terraform scripts
Support for using git-https and curl in Terraform
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog