Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/onsi/gomega to v1.16.0 #3

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 6, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
github.com/onsi/gomega require minor v1.13.0 -> v1.16.0

Release Notes

onsi/gomega

v1.16.0

Compare Source

Features

v1.15.0

Compare Source

1.15.0

Fixes

The previous version (1.14.0) introduced a change to allow Eventually and Consistently to support functions that make assertions. This was accomplished by overriding the global fail handler when running the callbacks passed to Eventually/Consistently in order to capture any resulting errors. Issue #​457 uncovered a flaw with this approach: when multiple Eventuallys are running concurrently they race when overriding the singleton global fail handler.

1.15.0 resolves this by requiring users who want to make assertions in Eventually/Consistently call backs to explicitly pass in a function that takes a Gomega as an argument. The passed-in Gomega instance can be used to make assertions. Any failures will cause Eventually to retry the callback. This cleaner interface avoids the issue of swapping out globals but comes at the cost of changing the contract introduced in v1.14.0. As such 1.15.0 introduces a breaking change with respect to 1.14.0 - however we expect that adoption of this feature in 1.14.0 remains limited.

In addition, 1.15.0 cleans up some of Gomega's internals. Most users shouldn't notice any differences stemming from the refactoring that was made.

v1.14.0

Compare Source

1.14.0

Features
  • gmeasure.SamplingConfig now suppers a MinSamplingInterval [e94dbca]
  • Eventually and Consistently support functions that make assertions [2f04e6e]
    • Eventually and Consistently now allow their passed-in functions to make assertions.
      These assertions must pass or the function is considered to have failed and is retried.
    • Eventually and Consistently can now take functions with no return values. These implicitly return nil
      if they contain no failed assertion. Otherwise they return an error wrapping the first assertion failure. This allows
      these functions to be used with the Succeed() matcher.
    • Introduce InterceptGomegaFailure - an analogue to InterceptGomegaFailures - that captures the first assertion failure
      and halts execution in its passed-in callback.
Fixes

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/git.luolix.top-onsi-gomega-1.x branch from f46f172 to 565e25d Compare October 6, 2021 11:27
@bastjan bastjan merged commit 13d880c into master Oct 6, 2021
@renovate renovate bot deleted the renovate/git.luolix.top-onsi-gomega-1.x branch October 6, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants