Change default root disk size to 100Gi

[DebakelOrakel]

RedHat lowered requirements for OpenShift node root disk size to 100Gi.
This change also makes the default root disk size configurable.

Checklist

• Keep pull requests small so they can be easily reviewed.
• Categorize the PR by setting a good title and adding one of the labels:
  bug, enhancement, documentation, change, breaking, dependency
  as they show up in the changelog
• Link this PR to related issues.

[simu]

IIRC, you need to add volume_size_gb in

terraform-openshift4-cloudscale/modules/node-group/main.tf

Lines 70 to 76 in c78e7d9

	lifecycle {
	ignore_changes = [
	skip_waiting_for_ssh_host_keys,
	image_slug,
	user_data,
	]
	}

to ensure that this doesn't try to recreate VMs for existing clusters or make sure that existing clusters have overrides, since we probably don't want to ignore all changes.

[DebakelOrakel]

IIRC, you need to add volume_size_gb in

terraform-openshift4-cloudscale/modules/node-group/main.tf

Lines 70 to 76 in c78e7d9

	lifecycle {
	ignore_changes = [
	skip_waiting_for_ssh_host_keys,
	image_slug,
	user_data,
	]
	}

to ensure that this doesn't try to recreate VMs for existing clusters or make sure that existing clusters have overrides, since we probably don't want to ignore all changes.

The Plan is to define the default_volume_size_gb in tenant-repos, but I suppose putting in lifecycle is more flexible 👍
This also means, the change is non-breaking.

[simu]

IIRC, you need to add volume_size_gb in

terraform-openshift4-cloudscale/modules/node-group/main.tf

Lines 70 to 76 in c78e7d9

	lifecycle {
	ignore_changes = [
	skip_waiting_for_ssh_host_keys,
	image_slug,
	user_data,
	]
	}

to ensure that this doesn't try to recreate VMs for existing clusters or make sure that existing clusters have overrides, since we probably don't want to ignore all changes.

The Plan is to define the default_volume_size_gb in tenant-repos, but I suppose putting in lifecycle is more flexible 👍 This also means, the change is non-breaking.

Yeah, I guess we'd have to do volume size changes manually anyway, even for changes that are possible (i.e. make the volume bigger).