Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename command probe type to exec #427

Merged
merged 3 commits into from
Mar 24, 2021
Merged

rename command probe type to exec #427

merged 3 commits into from
Mar 24, 2021

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Mar 24, 2021

No description provided.

marcinc
marcinc reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small comments

docs/reference/config-example.md Outdated Show resolved Hide resolved
docs/reference/config-params.md Outdated Show resolved Hide resolved
docs/reference/config-params.md Outdated Show resolved Hide resolved
docs/reference/config-params.md Outdated Show resolved Hide resolved
docs/reference/config-params.md Outdated Show resolved Hide resolved
docs/reference/config-params.md Outdated Show resolved Hide resolved
pkg/kev/config/labels.go Outdated Show resolved Hide resolved
pkg/kev/converter/kubernetes/types.go Outdated Show resolved Hide resolved
@mangas mangas force-pushed the kev-403-replace-command-with-exec branch from b60d45a to e296237 Compare March 24, 2021 13:03
marcinc
marcinc approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mangas mangas merged commit 1353ecf into master Mar 24, 2021
@mangas mangas deleted the kev-403-replace-command-with-exec branch March 24, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinc marcinc marcinc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mangas @marcinc