Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom CA secret name in Helm chart #1262

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

cezarsa
Copy link
Contributor

@cezarsa cezarsa commented Feb 20, 2024

This PR updates the helm chart allowing a custom CA secret to be used with the terranetes-controller. This is useful when we don't want the Helm chart to manage the CA secret and instead have it managed by external tools.

@cezarsa cezarsa requested a review from gambol99 as a code owner February 20, 2024 16:47
Copy link
Member

@gambol99 gambol99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM … thank you kindly @cezarsa

@gambol99 gambol99 changed the base branch from master to develop February 21, 2024 07:16
@gambol99 gambol99 merged commit a1ca177 into appvia:develop Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants