Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Error popups are not coming properly in small screen sizes #5098

Closed
2 tasks done
yatharth1706 opened this issue Feb 9, 2023 · 5 comments · Fixed by appwrite/console#284
Closed
2 tasks done
Assignees
Labels
bug Something isn't working product / console Console, UI and UX issues
Milestone

Comments

@yatharth1706
Copy link
Contributor

yatharth1706 commented Feb 9, 2023

👟 Reproduction steps

Go to functions > Create deployment > Manual and enter any wrong file of unsupported file type or don't enter any file and press create button, the error popup which comes in the right top comes below the modal if window screen is small or browser screen size is increased to more than 100%.

👍 Expected behavior

Error popup should come above the modal so that user will be able to see it properly

👎 Actual Behavior

Error pop up is coming below the modal
Screenshot 2023-02-09 223722

🎲 Appwrite version

Version 1.2.x

💻 Operating system

Windows

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@yatharth1706 yatharth1706 added the bug Something isn't working label Feb 9, 2023
@yatharth1706 yatharth1706 changed the title 🐛 Bug Report: Error popups are not coming properly in big screen sizes 🐛 Bug Report: Error popups are not coming properly in small screen sizes Feb 9, 2023
@stnguyen90 stnguyen90 added the product / console Console, UI and UX issues label Feb 9, 2023
@stnguyen90 stnguyen90 self-assigned this Feb 9, 2023
@stnguyen90
Copy link
Contributor

@yatharth1706, thanks for creating this issue! 🙏🏼 Looks like we're using addNotification() to display the error, but we should be capturing the error and binding it to the modal line in the createUser modal.

@stnguyen90 stnguyen90 added the good first issue Good for newcomers label Feb 10, 2023
@stnguyen90 stnguyen90 removed their assignment Feb 10, 2023
@martianshaan
Copy link

Hey @yatharth1706 I would like to take this one?? This issue is perfect point for me to understand Appwrite codebase and play a little bit.

@stnguyen90
Copy link
Contributor

@martianshaan, assigned! Thanks for your interest! 🙏🏼

@stnguyen90
Copy link
Contributor

@martianshaan, actually, sorry, it looks like we already have a PR for the fix.

@stnguyen90 stnguyen90 removed the good first issue Good for newcomers label Feb 10, 2023
@martianshaan
Copy link

Ok @stnguyen90 Thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product / console Console, UI and UX issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants