Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: function fist deployment, select validity #284

Merged
merged 4 commits into from
Feb 14, 2023
Merged

fix: function fist deployment, select validity #284

merged 4 commits into from
Feb 14, 2023

Conversation

ArmanNik
Copy link
Member

What does this PR do?

  • Displays first deployment building
  • fix select component required attribute not being respected (used customValidity)
  • fix create deployment data not being cleared correctly & error display
  • fix document creation required attribute not binded

Test Plan

Manual

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Feb 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
console ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 7:39AM (UTC)

@ArmanNik ArmanNik self-assigned this Feb 10, 2023
@stnguyen90 stnguyen90 linked an issue Feb 10, 2023 that may be closed by this pull request
🐛 Bug Report: Error popups are not coming properly in small screen sizes appwrite/appwrite#5098
Closed
2 tasks
TorstenDittmann
TorstenDittmann reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirm­foto 2023-02-13 um 13 09 31
trying to submit without a file leads to this

@TorstenDittmann TorstenDittmann merged commit dda54b0 into main Feb 14, 2023
@TorstenDittmann TorstenDittmann deleted the fix-function-and-more branch February 14, 2023 07:43
@ArmanNik ArmanNik mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees

@ArmanNik ArmanNik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Error popups are not coming properly in small screen sizes
2 participants
@ArmanNik @TorstenDittmann