Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6279 wrong validation of projectid #6298

Closed
wants to merge 1 commit into from
Closed

Fix 6279 wrong validation of projectid #6298

wants to merge 1 commit into from

Conversation

nick2432
Copy link

@nick2432 nick2432 commented Sep 21, 2023

What does this PR do?

It correct the validation for a project id . Project id cannot include capital letters, hyphens, or periods

Test Plan

i modified the regex to include all necessary characters

Before

Before

After

After

Before

bf

After

af

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
Copy link
Contributor

@nick2432, great job on this PR! The thing is, the validation is fine server side as we do want to restrict the characters used for the project id because of #5670. The thing that was incorrect was the helper text in the console.

Also, when making changes, make sure to look out for there are unit or E2E tests that need to be added or updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants