Merge pull request #1320 from appwrite/fix-qa-reviews

fix: qa reviews
appwrite · Aug 27, 2024 · 18c2cdc · 18c2cdc
2 parents b6341fa + 429cabf
commit 18c2cdc
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 14 deletions.
diff --git a/src/lib/components/billing/planComparisonBox.svelte b/src/lib/components/billing/planComparisonBox.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
     import { BillingPlan } from '$lib/constants';
     import { formatNum } from '$lib/helpers/string';
-    import { plansInfo, tierFree, tierPro, tierScale, type Tier } from '$lib/stores/billing';
+    import { plansInfo, tierFree, tierPro, type Tier } from '$lib/stores/billing';
     import { Card, SecondaryTabs, SecondaryTabsItem } from '..';
 
     let selectedTab: Tier = BillingPlan.FREE;
@@ -23,11 +23,11 @@
                 on:click={() => (selectedTab = BillingPlan.PRO)}>
                 {tierPro.name}
             </SecondaryTabsItem>
-            <SecondaryTabsItem
+            <!-- <SecondaryTabsItem
                 disabled={selectedTab === BillingPlan.SCALE}
                 on:click={() => (selectedTab = BillingPlan.SCALE)}>
                 {tierScale.name}
-            </SecondaryTabsItem>
+            </SecondaryTabsItem> -->
         </SecondaryTabs>
     </div>
 

diff --git a/src/lib/elements/table/tableScroll.svelte b/src/lib/elements/table/tableScroll.svelte
@@ -45,7 +45,11 @@
     };
 </script>
 
-<div class="table-with-scroll {classes}" class:u-margin-block-start-16={!noMargin} data-private>
+<div
+    class="table-with-scroll {classes}"
+    style:border-radius={noStyles ? '0' : ''}
+    class:u-margin-block-start-16={!noMargin}
+    data-private>
     <div class="table-wrapper" use:hasOverflow={(v) => (isOverflowing = v)}>
         <table
             class="table"

diff --git a/src/routes/(console)/onboarding/+page.svelte b/src/routes/(console)/onboarding/+page.svelte
@@ -32,11 +32,11 @@
               {
                   value: BillingPlan.PRO,
                   label: `${tierToPlan(BillingPlan.PRO).name} - ${formatCurrency($plansInfo.get(BillingPlan.PRO).price)}/month + add-ons`
-              },
-              {
-                  value: BillingPlan.SCALE,
-                  label: `${tierToPlan(BillingPlan.SCALE).name} - ${formatCurrency($plansInfo.get(BillingPlan.SCALE).price)}/month + usage`
               }
+              // {
+              //     value: BillingPlan.SCALE,
+              //     label: `${tierToPlan(BillingPlan.SCALE).name} - ${formatCurrency($plansInfo.get(BillingPlan.SCALE).price)}/month + usage`
+              // }
           ]
         : [];
 

diff --git a/src/routes/(console)/project-[project]/functions/function-[function]/+page.svelte b/src/routes/(console)/project-[project]/functions/function-[function]/+page.svelte
@@ -96,7 +96,7 @@
         },
         {
             id: 'size',
-            title: 'Deployment size',
+            title: 'Size',
             type: 'integer',
             show: true,
             width: 140,

diff --git a/...routes/(console)/project-[project]/functions/function-[function]/deploymentDomains.svelte b/...routes/(console)/project-[project]/functions/function-[function]/deploymentDomains.svelte
@@ -8,14 +8,17 @@
 </script>
 
 <div class="u-flex u-gap-4 u-cross-center">
-    <Trim alternativeTrim>
-        <a href={`http://${domain.rules[0].domain}`} target="_blank">
+    <a
+        href={`http://${domain.rules[0].domain}`}
+        target="_blank"
+        class="u-flex u-gap-4 u-cross-center">
+        <Trim alternativeTrim>
             <span class="link">
                 {domain.rules[0].domain}
             </span>
-        </a>
-    </Trim>
-    <span class="icon-external-link" aria-hidden="true" />
+        </Trim>
+        <span class="icon-external-link" aria-hidden="true" />
+    </a>
     {#if domain.rules.length > 1}
         <DropList bind:show={showDropdown} scrollable>
             <Pill button on:click={() => (showDropdown = !showDropdown)}>