Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification on authenticator verification #1299

Conversation

ItzNotABug
Copy link
Contributor

@ItzNotABug ItzNotABug commented Aug 16, 2024

What does this PR do?

Fixes #1298

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link

vercel bot commented Aug 16, 2024

@ItzNotABug is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise. Please make sure we get a design review done.

@ItzNotABug
Copy link
Contributor Author

Looks good code wise. Please make sure we get a design review done.

This has been approved for the time being.

@stnguyen90
Copy link
Contributor

Merging because Christy approved earlier and Sara approved internally.

@stnguyen90 stnguyen90 merged commit 21efe03 into appwrite:main Aug 30, 2024
1 of 2 checks passed
@ItzNotABug ItzNotABug deleted the add-notification-on-authenticator-verification branch August 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Enhancement: Show notification after adding (and verifying) authenticator
4 participants