Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various fixes from demo and QA v10 #131

Merged
merged 3 commits into from
Nov 14, 2022
Merged

fix: various fixes from demo and QA v10 #131

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91d4224
fix: verification email / phone
ArmanNik Nov 11, 2022
9e7573e
fix: small fixes
ArmanNik Nov 11, 2022
dca75b4
fix: set async to true
ArmanNik Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/console/onboarding/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
</Pill>
</div>
{:else}
<CustomId bind:show={showCustomId} name="Project ID" bind:id />
<CustomId bind:show={showCustomId} name="Project" bind:id />
{/if}
<Button fullWidth submit disabled={loading}>Create project</Button>
</FormList>
Expand Down
3 changes: 1 addition & 2 deletions src/routes/console/project-[project]/auth/user-[user]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
showVerifcationDropdown = false;
try {
await sdkForProject.users.updateEmailVerification($user.$id, !$user.emailVerification);
$user.emailVerification = !$user.emailVerification;
invalidate(Dependencies.USER);
addNotification({
message: `${$user.name || $user.email || $user.phone || 'The account'} has been ${
$user.emailVerification ? 'verified' : 'unverified'
Expand Down Expand Up @@ -271,7 +271,6 @@
{$user.emailVerification ? 'Unverify' : 'Verify'} account
</Button>
{:else if $user.phone}
test
<Button secondary on:click={() => updateVerificationPhone()}>
{$user.phoneVerification ? 'Unverify' : 'Verify'} account
</Button>
Expand Down
6 changes: 5 additions & 1 deletion src/routes/console/project-[project]/functions/function-[function]/execute.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
let show = false;
let data: string = null;
let showJson = false;
let submitting = false;

const example = `
{
Expand All @@ -24,6 +25,7 @@
}

const handleSubmit = async () => {
submitting = true;
try {
await sdkForProject.functions.createExecution(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lest pass async as true, so we don't have to wait for cold starts as well 👍🏻

selectedFunction.$id,
Expand All @@ -39,6 +41,8 @@
type: 'error',
message: error.message
});
} finally {
submitting = false;
}
};

Expand All @@ -61,6 +65,6 @@

<svelte:fragment slot="footer">
<Button text on:click={close}>Cancel</Button>
<Button submit>Execute Now</Button>
<Button disabled={submitting} submit>Execute Now</Button>
</svelte:fragment>
</Modal>