Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom ID validation and char length counter #167

Merged
merged 9 commits into from
Feb 8, 2023

Conversation

ArmanNik
Copy link
Member

@ArmanNik ArmanNik commented Nov 17, 2022

What does this PR do?

Adds frontend validation to the custom ID component, limits the length to 36 characters, and adds a character counter at the end of the input.

  • add correct CSS classes

Test Plan

  • Create unit tests

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
console ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:27AM (UTC)

@TorstenDittmann TorstenDittmann merged commit 58282a8 into main Feb 8, 2023
@TorstenDittmann TorstenDittmann deleted the feat-custom-id-pattern branch February 8, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants