Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: createIndex attribute select changing all other selects #185

Merged
merged 8 commits into from
Nov 23, 2022
Merged

fix: createIndex attribute select changing all other selects #185

merged 8 commits into from
Nov 23, 2022

Conversation

TGlide
Copy link
Contributor

@TGlide TGlide commented Nov 23, 2022 •
edited
Loading

What does this PR do?

  • Fixes a bug in which changing the last Attribute select value would change all other Attribute select values. I also re-factored a bit of the code.
  • Fixes a bug in which if you add a new attribute, and then delete it, you can't create an index

Test Plan

Manual

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@TGlide TGlide added the bug Something isn't working label Nov 23, 2022
@TGlide TGlide self-assigned this Nov 23, 2022
@vercel
Copy link

vercel bot commented Nov 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 5:25PM (UTC)

@ArmanNik ArmanNik linked an issue Nov 23, 2022 that may be closed by this pull request
🐛 Bug Report: Index creation. All previews values changed to the value of the last attribute which was added appwrite/appwrite#4762
Closed
2 tasks
@TorstenDittmann TorstenDittmann merged commit af3d741 into main Nov 23, 2022
@TorstenDittmann TorstenDittmann deleted the fix-4762-index-creation-preview-values branch November 23, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmanNik ArmanNik ArmanNik approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees

@TGlide TGlide

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@TGlide @stnguyen90 @TorstenDittmann @ArmanNik