Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: empty arrays UI #216

Merged
merged 12 commits into from
Feb 9, 2023
Merged

Feat: empty arrays UI #216

merged 12 commits into from
Feb 9, 2023

Conversation

TGlide
Copy link
Contributor

@TGlide TGlide commented Dec 12, 2022

What does this PR do?

Creates an AttributeForm component, that substitutes the forms on create document and update document. This component also changes the logic of array fields, allowing documents with empty array attributes to be created.

Test Plan

Manual

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes

@TGlide TGlide added the enhancement New feature or request label Dec 12, 2022
@TGlide TGlide self-assigned this Dec 12, 2022
@vercel
Copy link

vercel bot commented Dec 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
console ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 3:19PM (UTC)

Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirm­foto 2023-01-10 um 15 15 23

the Add item button is not vertically aligned with the attribute name 👍🏻

@TGlide
Copy link
Contributor Author

TGlide commented Jan 23, 2023

Bildschirm­foto 2023-01-10 um 15 15 23

the Add item button is not vertically aligned with the attribute name 👍🏻

I can't seem to reproduce:
image

Any particular steps you went through?

feat: display attribute types on input fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: An array cannot be empty anymore
2 participants