Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enter "delete" to continue label #226

Conversation

jalajcodes
Copy link
Contributor

@jalajcodes jalajcodes commented Dec 27, 2022

What does this PR do?

  • Change the id attribute of Enter "delete" to continue inputText from name to project-name so that the label works properly.

Test Plan

Manual

Related PRs and Issues

This PR resolves appwrite/appwrite#4863

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Dec 27, 2022

@jalajcodes is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@jalajcodes
Copy link
Contributor Author

@stnguyen90 I noticed similar issues in other modals also,

  • If we open a Organization's settings page, and then click on the invite button the name input label has same problem.
  • On a project settings page, if we click on the profile menu at the top right, and then click on new organization, then again the name input label doesn't work properly.

If you want I can fix them in the same PR or we can create another good first issue for other first timers to pick up.

@stnguyen90
Copy link
Contributor

stnguyen90 commented Jan 10, 2023

If you want I can fix them in the same PR or we can create another good first issue for other first timers to pick up.

@jalajcodes you can work on the fix too

@jalajcodes
Copy link
Contributor Author

jalajcodes commented Jan 14, 2023

If you want I can fix them in the same PR or we can create another good first issue for other first timers to pick up.

@jalajcodes you can work on the fix too

Done @stnguyen90

@TorstenDittmann TorstenDittmann merged commit f50990f into appwrite:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Enter "delete" to continue label on Delete Project Modal
4 participants