Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add console footer #249

Merged
merged 8 commits into from
Feb 24, 2023
Merged

Feat: add console footer #249

merged 8 commits into from
Feb 24, 2023

Conversation

TGlide
Copy link
Contributor

@TGlide TGlide commented Feb 3, 2023

What does this PR do?

Adds a footer to the console

Test Plan

Manual

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes

@TGlide TGlide added the enhancement New feature or request label Feb 3, 2023
@TGlide TGlide self-assigned this Feb 3, 2023
@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
console ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 10:59AM (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 10:59AM (UTC)

@TorstenDittmann
Copy link
Contributor

Bildschirm­foto 2023-02-06 um 09 17 51
it looks kinda weird on this screen, can you check with the design team?

@TGlide
Copy link
Contributor Author

TGlide commented Feb 7, 2023

Bildschirm­foto 2023-02-06 um 09 17 51 it looks kinda weird on this screen, can you check with the design team?

Fixed the spacing issue, but design requested aditional changes. GOing to convert this into draft because it may require changes in pink.

@TGlide TGlide marked this pull request as draft February 7, 2023 13:13
@ArmanNik
Copy link
Member

ArmanNik commented Feb 17, 2023

image

We should probably add u-cross-center to align the icons and the text 👍

@TGlide
Copy link
Contributor Author

TGlide commented Feb 17, 2023

image

We should probably add u-cross-center to align the icons and the text 👍

Which browser is this happening on? I tested on Firefox and Chrome, and it's aligned 🤔

src/lib/stores/sdk.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants