Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: organization screens #39

Merged
merged 43 commits into from
Sep 1, 2022
Merged

Feat: organization screens #39

merged 43 commits into from
Sep 1, 2022

Conversation

ArmanNik
Copy link
Member

@ArmanNik ArmanNik commented Aug 12, 2022

What does this PR do?

Implementation of the new organization screens

  • settings page
  • members page
  • creation / deletion logic (update modals)
  • feat: open new organization modal from dropdown and header menu
  • fix: breadcrumbs are wrong on reload inside a project
  • feat: forced modal when the last organization has been deleted
  • feat: create organization routes
    feat: number of bucket tags shown depends on the width to do in another PR.

@vercel
Copy link

vercel bot commented Aug 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-console ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 10:55AM (UTC)

@ArmanNik ArmanNik changed the title Draft: organization screens Feat: organization screens Aug 24, 2022
@eldadfux
Copy link
Member

Great work, a few comments.

image

  • Users avatars are not sized properly. We also discussed to fetch avatars x2 the required size for retina screens. Would be cool to make sure we enforce that in the codebase for other maintainers don't have to be aware of this requirement.
  • Instead of 0 APPS would be better to say NO APPS.

@eldadfux
Copy link
Member

Do we have any limit in place or scrolling as the list of orgs become bigger and bigger?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants