Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests branch merge #4

Merged
merged 14 commits into from
May 13, 2022
Merged

Tests branch merge #4

merged 14 commits into from
May 13, 2022

Conversation

ArmanNik
Copy link
Member

@ArmanNik ArmanNik commented May 9, 2022

@TorstenDittmann let me know if the implementation for the copy component fallback is correct. The same goes for component tests.

As for the rest:

  • The radio input needs a group test. Should I create a mock component and create a separate test or there is a better way?
  • The test for "state changes" to the select input component might be a little brittle maybe 🙃

@vercel
Copy link

vercel bot commented May 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-console ✅ Ready (Inspect) Visit Preview May 13, 2022 at 4:27PM (UTC)

src/lib/components/copy.svelte Outdated Show resolved Hide resolved
src/lib/components/copy.svelte Outdated Show resolved Hide resolved
src/lib/components/copy.svelte Outdated Show resolved Hide resolved
@ArmanNik
Copy link
Member Author

@TorstenDittmann let me know if anything is missing :)

@TorstenDittmann TorstenDittmann merged commit 4997d2c into main May 13, 2022
@TorstenDittmann TorstenDittmann deleted the tests branch May 13, 2022 16:44
stnguyen90 added a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants