Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user labels to user list and detail pages #457

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jun 2, 2023

What does this PR do?

Add user labels to user list and detail pages

Test Plan

Manual:

Users List

image

User Detail

without error

image

with error

image

Related PRs and Issues

Depends on:

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 0:17am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 0:17am
console-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 0:17am

@stnguyen90
Copy link
Contributor Author

@chenparnasa, here's what I have so far for the user labels.

Copy link
Contributor

@heyCarla heyCarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @chenparnasa left you some comments about this in Figma re: replacing the original helper text with the warning message if an invalid tag is added to the input field. Otherwise I like the idea of calling out the specific label in the warning!

@chenparnasa
Copy link
Contributor

@stnguyen90 I left comments in Figma on how we should handle the helper texts :)

@stnguyen90
Copy link
Contributor Author

@TorstenDittmann, would you please review this when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants