Add user labels to user list and detail pages #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@chenparnasa, here's what I have so far for the user labels. |
stnguyen90
commented
Jun 2, 2023
stnguyen90
commented
Jun 2, 2023
stnguyen90
force-pushed
the
feat-user-labels
branch
from
32d8575
to
ff2ae0a
Compare
stnguyen90
force-pushed
the
feat-user-labels
branch
from
ff2ae0a
to
684f01f
Compare
heyCarla
reviewed
Jun 6, 2023
There was a problem hiding this comment.
I think @chenparnasa left you some comments about this in Figma re: replacing the original helper text with the warning message if an invalid tag is added to the input field. Otherwise I like the idea of calling out the specific label in the warning!
|
@stnguyen90 I left comments in Figma on how we should handle the helper texts :) |
stnguyen90
force-pushed
the
feat-user-labels
branch
from
684f01f
to
ac80004
Compare
stnguyen90
force-pushed
the
feat-user-labels
branch
from
ac80004
to
385ff48
Compare
ArmanNik
reviewed
Jul 5, 2023
src/routes/console/project-[project]/auth/user-[user]/updateLabels.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/user-[user]/updateLabels.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/user-[user]/updateLabels.svelte
Outdated
Show resolved
Hide resolved
stnguyen90
force-pushed
the
feat-user-labels
branch
from
385ff48
to
a8d6f7b
Compare
ArmanNik
approved these changes
Jul 5, 2023
2 tasks
stnguyen90
force-pushed
the
feat-user-labels
branch
from
a8d6f7b
to
82d6a80
Compare
|
@TorstenDittmann, would you please review this when you get a chance? |
This was referenced Jul 25, 2023
stnguyen90
force-pushed
the
feat-user-labels
branch
from
82d6a80
to
126c6ea
Compare
stnguyen90
force-pushed
the
feat-user-labels
branch
from
126c6ea
to
d6d960f
Compare
TorstenDittmann
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add user labels to user list and detail pages
Test Plan
Manual:
Users List
User Detail
without error
with error
Related PRs and Issues
Depends on:
Have you read the Contributing Guidelines on issues?
Yes