Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appwrite console internationalization : Typesafe-i18n #459

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

goswamianshuman
Copy link

What does this PR do?

  • adding i18n feature using typesafe-i18n library

Test Plan

  • no code structure was changed

Related PRs and Issues

@vercel
Copy link

vercel bot commented Jun 4, 2023

@goswamianshuman is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@goswamianshuman
Copy link
Author

@TorstenDittmann, @TGlide, @ArmanNik tagging you guys here for a review of typesafe-i18n library for the internationalization on the recommendations of @TorstenDittmann.🙂

@TGlide TGlide added the enhancement New feature or request label Jun 6, 2023
@TGlide
Copy link
Contributor

TGlide commented Jun 6, 2023

Hi @goswamianshuman ! Thanks for the PR. I'm confused though, why are there 2 separate PRs? Does this PR contain code from #451? Or is this PR supposed to be merged only after #451?

@goswamianshuman
Copy link
Author

Hi @goswamianshuman ! Thanks for the PR. I'm confused though, why are there 2 separate PRs? Does this PR contain code from #451? Or is this PR supposed to be merged only after #451?

Hey @TGlide actully the following PR is performed with typesafe-i18n library Torsten told me that please create a seperate library for typesafe-i18n ,

#451 is performed by using i18next library.

the method for performing both the libraries are different that is why Torsten recommended to create a new PR.

Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible if you only include code for typesafe-i18n in this PR so its going to be easier for review? 👍🏻

@goswamianshuman
Copy link
Author

Would it be possible if you only include code for typesafe-i18n in this PR so its going to be easier for review? 👍🏻

there is only typesafe-i18n code here as per your recommendation I removed everything just kept typesafe-i18n

src/i18n/en/index.ts Outdated Show resolved Hide resolved
src/lib/components/LanguageSelector.svelte Outdated Show resolved Hide resolved
src/routes/+layout.svelte Outdated Show resolved Hide resolved
src/routes/auth/magic-url/+page.svelte Outdated Show resolved Hide resolved
@goswamianshuman
Copy link
Author

hey, @TGlide have a look here, https://github.com/ivanhofer/typesafe-i18n-demo-svelte/tree/master I think this might resolve many doubts regarding this PR.

src/routes/console/onboarding/+page.svelte Outdated Show resolved Hide resolved
src/routes/console/onboarding/+page.svelte Outdated Show resolved Hide resolved
src/lib/i18n/de/de.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants