-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appwrite console internationalization : Typesafe-i18n #459
base: main
Are you sure you want to change the base?
Appwrite console internationalization : Typesafe-i18n #459
Conversation
@goswamianshuman is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
@TorstenDittmann, @TGlide, @ArmanNik tagging you guys here for a review of typesafe-i18n library for the internationalization on the recommendations of @TorstenDittmann.🙂 |
Hi @goswamianshuman ! Thanks for the PR. I'm confused though, why are there 2 separate PRs? Does this PR contain code from #451? Or is this PR supposed to be merged only after #451? |
Hey @TGlide actully the following PR is performed with typesafe-i18n library Torsten told me that please create a seperate library for typesafe-i18n , #451 is performed by using i18next library. the method for performing both the libraries are different that is why Torsten recommended to create a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible if you only include code for typesafe-i18n
in this PR so its going to be easier for review? 👍🏻
there is only typesafe-i18n code here as per your recommendation I removed everything just kept typesafe-i18n |
hey, @TGlide have a look here, https://github.com/ivanhofer/typesafe-i18n-demo-svelte/tree/master I think this might resolve many doubts regarding this PR. |
What does this PR do?
Test Plan
Related PRs and Issues