Replace sorting by $createdAt with natural order #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
By sorting on Query.orderDesc(''), results are still ordered by
newest results first, but the performance is much better than
sorting by $createdAt.
stnguyen90
force-pushed
the
feat-default-sort
branch
from
2945f6b
to
22961b5
Compare
christyjacob4
approved these changes
Aug 9, 2023
ArmanNik
approved these changes
Aug 9, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By sorting on Query.orderDesc(''), results are still ordered by newest results first, but the performance is much better than sorting by $createdAt.
Test Plan
Manual
Related PRs and Issues
Previous PR where we removed
Query.orderDesc('$createdAt')due to performance:Have you read the Contributing Guidelines on issues?
Yes