Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template configuration to show supported runtimes #547

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Sep 13, 2023

What does this PR do?

There are times when people jump into creating the function without reading the template details. Because templates only support certain runtime versions, it's important to show the supported runtimes in the wizard or else the developer will be confused why their enabled incompatible runtime doesn't show in the Runtime dropdown.

Test Plan

Manual:

image

Simulated w/ lots of runtimes:

image

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 6:51pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 6:51pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 6:51pm

There are times when people jump into creating the function without
reading the template details. Because templates only support certain
runtime versions, it's important to show the supported runtimes in the
wizard or else the developer will be confused why their enabled
incompatible runtime doesn't show in the Runtime dropdown.
A sorted list is easier to scan if a developer is looking for a specific version.
@TorstenDittmann TorstenDittmann merged commit 14d963a into main Sep 14, 2023
2 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-show-template-supported-runtimes branch September 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants