Fix Policy and Terms Page #578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RamGoel is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
|
@TorstenDittmann please review it. |
RamGoel
changed the title
|
@eldadfux @TorstenDittmann can you review it. |
|
Thanks for raising this! Unfortunately, we don't want to add this at the moment. If you wish to contribute as part of Hacktoberfest, please look for issues labeled "hacktoberfest". |
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On register page, and some footer links, the url for policy and terms page are incorrect.
That's why it was giving 404 error. It corrects the url's from
/policy/privacy->/privacy' and 'policy/terms->/terms.IMPORTANT
The Terms and Conditions page is not built completely yet! View
Test Plan
I have verified the final behaviour by running out the flow of visiting both pages through register page and footer links.
Executed
npm run formatto preserve the style of code.Related PRs and Issues
Solves appwrite/appwrite#6485 and appwrite/website#191
Have you read the Contributing Guidelines on issues?
Yes