Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6279 wrong validation of projectid #589

Merged

Conversation

nick2432
Copy link
Contributor

@nick2432 nick2432 commented Oct 16, 2023

What does this PR do?

update the helper text

Fixes appwrite/appwrite#6279

Test Plan

I update the CustomId component when name is project, it will use a new InputProjectId rather than InputId.

I updated the unit tests, and I verified that they all passed successfully.

before
before

after
after
![Screenshot from 2023-10-16 10-13-59](https://github.com/appwrite/console/assets/77477551/ad2c5ffe-5b81-4ccd-aeea-ab
Screenshot from 2023-10-16 10-14-08
d58c280610)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@vercel
Copy link

vercel bot commented Oct 16, 2023

@nick2432 is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@stnguyen90 stnguyen90 self-requested a review October 16, 2023 05:35
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 7:07pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 7:07pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 7:07pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 7:07pm

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use some shorter syntax and we are good imo 👍🏻

src/lib/components/customId.svelte Outdated Show resolved Hide resolved
src/routes/console/onboarding/+page.svelte Outdated Show resolved Hide resolved
nick2432 and others added 3 commits October 18, 2023 17:44
Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
…velte

Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the validation works well:

image

The only minor recommendation is to remove the package-lock.json change.

package-lock.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants