Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document IDs not updating when switching between collections #612

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Nov 4, 2023

What does this PR do?

Ensure document IDs are destroyed and recreated so the text is updated

Fixes appwrite/appwrite#6497

Test Plan

Manual:

Screen.Recording.2023-11-03.at.5.17.17.PM.mov

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 0:21am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 0:21am
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 0:21am
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 0:21am

@stnguyen90
Copy link
Contributor Author

@TorstenDittmann so this fixes the document IDs not updating, but the truncating doesn't seem to be working right when you switch pages or on window resize 😕

@TorstenDittmann TorstenDittmann merged commit f7c34a1 into main Nov 9, 2023
6 checks passed
@TorstenDittmann TorstenDittmann deleted the fix-6497-document-ids branch November 9, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Document IDs Don't Update when Changing Collections
3 participants