Implement Custom Domains Wizard and List #64
Conversation
|
@stnguyen90 is attempting to deploy a commit to the appwrite Team on Vercel. To accomplish this, @stnguyen90 needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
stnguyen90
force-pushed
the
feat-custom-domains
branch
from
0d60d15
to
ed65640
Compare
|
An owner of the appwrite Team on Vercel accepted @stnguyen90's request to join. @stnguyen90's commit is now being deployed. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/routes/console/project-[project]/settings/domains/wizard/step1.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/settings/domains/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/settings/domains/wizard/_cnameTable.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/settings/domains/wizard/_verificationBox.svelte
Outdated
Show resolved
Hide resolved
stnguyen90
force-pushed
the
feat-custom-domains
branch
from
ed65640
to
dddd92f
Compare
| export let maxlength: number = null; | ||
|
|
||
| // https://stackoverflow.com/questions/10306690/what-is-a-regular-expression-which-will-match-a-valid-domain-name-without-a-subd | ||
| const pattern = String.raw`^((?!-))(xn--)?[a-z0-9][a-z0-9-_]{0,61}[a-z0-9]{0,1}\.(xn--)?([a-z0-9-]{1,61}|[a-z0-9-]{1,30}\.[a-z]{2,})$`; |
There was a problem hiding this comment.
I tested various domains, but they are always invalid, is this pattern correct?
There was a problem hiding this comment.
whoops looks like it wasn't working for more subdomains.
| {#if isVerifying[domain.$id]} | ||
| <div | ||
| class="loader" | ||
| style="color: hsl(var(--color-neutral-50)); inline-size: 1.25rem; block-size: 1.25rem" /> |
There was a problem hiding this comment.
We should probably let the UI library handle all these inline styles. Let's add a TODO: remove inline styles to the file remember :)
| import { domain } from './store'; | ||
|
|
||
| const parts = $domain.name.split('.'); | ||
| const registerable = [parts[parts.length - 2], parts[parts.length - 1]].join('.'); |
There was a problem hiding this comment.
Would this work for api.appwrite.example.com?
There was a problem hiding this comment.
This seems right:
Although, I'm not sure what the expected outcome is for something like example.com:
src/routes/console/project-[project]/settings/domains/wizard/step1.svelte
Show resolved
Hide resolved
stnguyen90
force-pushed
the
feat-custom-domains
branch
from
dddd92f
to
e3495d9
Compare
|
@stnguyen90 the interceptor is merged now 👍🏻 |
stnguyen90
force-pushed
the
feat-custom-domains
branch
from
e3495d9
to
27cd364
Compare
|
stnguyen90
force-pushed
the
feat-custom-domains
branch
from
27cd364
to
bc9694e
Compare
@TorstenDittmann, updated! |
What does this PR do?
Implement Custom Domains List and Wizard.
Test Plan
Manual
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes