Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Mock numbers #798

Merged
merged 16 commits into from
Jul 3, 2024
Merged

Feat: Mock numbers #798

merged 16 commits into from
Jul 3, 2024

Conversation

christyjacob4
Copy link
Member

@christyjacob4 christyjacob4 commented Feb 11, 2024

What does this PR do?

Add support for mock phone numbers

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-1.6 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:14am
console-billing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:14am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:14am
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:14am
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:14am

@stnguyen90
Copy link
Contributor

@christyjacob4, what's the PR in Appwrite that adds this feature?

@christyjacob4
Copy link
Member Author

@@ -68,6 +69,7 @@ export const sdk = {
health: new Health(clientConsole),
locale: new Locale(clientConsole),
projects: new Projects(clientConsole),
auth: new Auth(clientConsole),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TorstenDittmann is there a way to combine this into the projects class ? Because that is where this method is supposed to be

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the spec is generated and a sdk is released it will be automatically part of that 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants