Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboarding #82

Merged
merged 19 commits into from
Nov 11, 2022
Merged

feat: onboarding #82

merged 19 commits into from
Nov 11, 2022

Conversation

TorstenDittmann
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@vercel
Copy link

vercel bot commented Oct 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 10:53AM (UTC)

@TorstenDittmann TorstenDittmann changed the title draft: onboarding feat: onboarding Nov 10, 2022
Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to invalidate the data after a platform/key creation, otherwise, I still see the empty layout.

Also, key/platform creation are missing notifications

src/lib/components/card.svelte Show resolved Hide resolved
@TorstenDittmann TorstenDittmann merged commit 98939b8 into main Nov 11, 2022
@TorstenDittmann TorstenDittmann deleted the feat-onboarding branch November 11, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants