Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support for CURL in Swoole #12

Closed
wants to merge 2 commits into from
Closed

Conversation

Meldiron
Copy link
Contributor

What does this PR do?

Adds async support to curl()

Test Plan

Manual QA with log streaming in Appwrite

Related PRs and Issues

x

Have you read the Contributing Guidelines on issues?

Yes

@eldadfux
Copy link
Member

@Meldiron do we still need this or can we close this PR?

@Meldiron
Copy link
Contributor Author

Doesnt seem to be nessessary anymore.

@Meldiron
Copy link
Contributor Author

Meldiron commented Aug 3, 2023

seems relevant. We are facing some CURL bugs that are most likely related to these changes

@Meldiron
Copy link
Contributor Author

Meldiron commented Aug 3, 2023

Closing in favour of #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants