This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Ensure API endpoints have required params first #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewenyu99
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Looks good to me. @stnguyen90 How are params sorted within required/non-required groups? Does it match SDK generator, too?
@gewenyu99, yes, they match. |
|
This should already come in the correct order from Appwrite, where did we see this? |
eldadfux
approved these changes
Jul 18, 2023
@eldadfux probably 1.3 when we made the param optional. |
This was referenced Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our SDKs sort API params to make required params first (because most languages need to have required params before optional). This fixes a bug where we weren't properly sorting params in the body/payload.
Closes: appwrite/appwrite#5676
Test Plan
Manual:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes