Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.x #58

Merged
merged 8 commits into from
Aug 27, 2024
Merged

1.6.x #58

merged 8 commits into from
Aug 27, 2024

Conversation

christyjacob4
Copy link
Member

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@@ -92,7 +92,7 @@ class Avatars(client: Client) : Service(client) {
/**
* Get favicon
*
* Use this endpoint to fetch the favorite icon (AKA favicon) of any remote website URL.
* Use this endpoint to fetch the favorite icon (AKA favicon) of any remote website URL.This endpoint does not follow HTTP redirects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newlines are missing before all This endpoint does not follow HTTP redirects instances

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-27 at 3 20 42 PM

As I can see the MD files contain the new line. But I guess twig strips them. I believe this is not a blocker right?

@christyjacob4 christyjacob4 merged commit 85fac9d into main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants