Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msg91 params #120

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix msg91 params #120

merged 1 commit into from
Apr 2, 2024

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

Update the params since the MSG91 provider uses template ID instead of a from phone number

Test Plan

Manual

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

README.md Outdated
Comment on lines 63 to 67
<<<<<<< Updated upstream
5.0.1
=======
5.0.2
>>>>>>> Stashed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the merge conflict wasnt resolved properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christyjacob4, fixed! Thanks for catching that!

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

@christyjacob4 christyjacob4 merged commit 0152cab into dev Apr 2, 2024
@christyjacob4 christyjacob4 deleted the fix-msg91-params branch April 2, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants