added test #159
Merged
added test #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
Jun 21, 2023
lib/query.dart
Outdated
Comment on lines
23
to
27
| /// Filter resources where [attribute] is less than [value]. | ||
| /// | ||
| /// [value] can be a single value or a list. If a list is used | ||
| /// the query will return resources where [attribute] is equal | ||
| /// to any of the values in the list. |
There was a problem hiding this comment.
I think lessThan, greaterThan, (and equal variants) only support 1 value, not array.
Meldiron
reviewed
Jun 21, 2023
lib/query.dart
Outdated
| static String greaterThanEqual(String attribute, dynamic value) => | ||
| _addQuery(attribute, 'greaterThanEqual', value); | ||
|
|
||
| /// Filter resources where by searching [attribute] for [value]. | ||
| /// | ||
| /// A fulltext index on [attribute] is required for this query to work. |
There was a problem hiding this comment.
I think it's not required since 1.3. Let's not mention fulltext index.
Meldiron
reviewed
Jun 21, 2023
Comment on lines
-21
to
+28
| cookie_jar: ^3.0.1 | ||
| device_info_plus: ^8.1.0 | ||
| flutter_web_auth_2: ^2.0.4 | ||
| http: ^0.13.5 | ||
| package_info_plus: ^3.0.3 | ||
| path_provider: ^2.0.13 | ||
| web_socket_channel: ^2.3.0 | ||
| universal_html: ^2.0.9 | ||
| cookie_jar: ^4.0.3 | ||
| device_info_plus: ^9.0.2 | ||
| flutter_web_auth_2: ^2.1.4 | ||
| http: '>=0.13.6 <1.0.1' | ||
| package_info_plus: ^4.0.2 | ||
| path_provider: ^2.0.15 | ||
| web_socket_channel: ^2.4.0 | ||
| universal_html: ^2.2.2 |
There was a problem hiding this comment.
Possible breakign change for cookie_jar, device_info_plus, package_info_plus,
There was a problem hiding this comment.
(just a comment. if it works, all good)
Meldiron
approved these changes
Jun 21, 2023
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)