Fix: CLI syntax #556
Merged
Fix: CLI syntax #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Whoopise 🙈 We released a syntax error. This PR solves it.
What happened is that suggestion on GitHub was accepted, and tests passed because they didn't test this file. To prevent this in the future, we could consider TypeScript (and building) for CLI.
Test Plan
Tests sadly don't test init/deploy command - that would require proper specs and spin up Appwrite instance during test.
For now, manual QA:
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes