Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating a user throws an error #660

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Conversation

imf-ali
Copy link
Contributor

@imf-ali imf-ali commented May 28, 2023

What does this PR do?

Creates user successfully without errors.

Behaviour

image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@imf-ali imf-ali requested a review from stnguyen90 May 28, 2023 21:03
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

templates/cli/lib/parser.js.twig Outdated Show resolved Hide resolved
@stnguyen90 stnguyen90 changed the title [Fix] Creating a user throws an error Fix creating a user throws an error Jun 1, 2023
@stnguyen90 stnguyen90 linked an issue Jun 1, 2023 that may be closed by this pull request
2 tasks
@imf-ali imf-ali requested a review from stnguyen90 June 3, 2023 11:34
@imf-ali
Copy link
Contributor Author

imf-ali commented Jun 3, 2023

I have addressed the comments. Kindly have a look @stnguyen90 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Creating a user throws an error
3 participants